linux-kernel - Re: [PATCH v2 1/2] Staging: rtl8192e: Fix parenthesis alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b063faf-f882-4f3c-bd11-9695d1ba9917@stanley.mountain>
Date: Fri, 23 Aug 2024 11:40:23 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Gabriel Maciel Raad <ffunctor@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH v2 1/2] Staging: rtl8192e: Fix parenthesis alignment

On Thu, Aug 22, 2024 at 09:08:37PM -0300, Gabriel Maciel Raad wrote:
> Fix parenthesis alingment in rtl92e_leisure_ps_enter to silence the
> following checkpatch.pl warning:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Gabriel Maciel Raad <ffunctor@...il.com>
> ---
> Changes in v2:
> - Split the changes in two patches
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> index 5aac9110bff6..1f881c27d4b4 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> @@ -204,7 +204,7 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
>  					&priv->rtllib->pwr_save_ctrl;
>  
>  	if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> -	    (priv->rtllib->link_state == MAC80211_LINKED)))
> +	      (priv->rtllib->link_state == MAC80211_LINKED)))
>  		return;

It would be nicer to write this as:

        if (priv->rtllib->iw_mode != IW_MODE_INFRA ||
            priv->rtllib->link_state != MAC80211_LINKED)
                return;
regards,
dan carpenter