linux-kernel - Re: [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of kmemdup for multiple allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd6b7276-cfb5-41ce-a25d-6278fe4d971e@kernel.org>
Date: Fri, 23 Aug 2024 10:56:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shen Lichuan <shenlichuan@...o.com>, s.nawrocki@...sung.com,
 linus.walleij@...aro.org
Cc: alim.akhtar@...sung.com, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of
 kmemdup for multiple allocation

On 23/08/2024 10:24, Shen Lichuan wrote:
> Let the kememdup_array() take care about
> multiplication and possible overflows.
> 
> Using kmemdup_array() is more appropriate 
> and makes the code easier to audit.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index e4464ee815f9..da24890f27f7 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -122,8 +122,8 @@ static int add_map_configs(struct device *dev, struct pinctrl_map **map,
>  	if (WARN_ON(*num_maps == *reserved_maps))
>  		return -ENOSPC;
>  
> -	dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs),
> -			      GFP_KERNEL);
> +	dup_configs = kmemdup_array(configs, num_configs,
> +					sizeof(*dup_configs), GFP_KERNEL);

Misaligned and wrapped too early.

>  

Best regards,
Krzysztof