linux-kernel - Re: [PATCH v2] gpio: rockchip: avoid division by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3370558.KgjxqYA5nG@diego>
Date: Fri, 23 Aug 2024 11:27:38 +0200
From: Heiko Stübner <heiko@...ech.de>
To: linus.walleij@...aro.org, brgl@...ev.pl, linux-gpio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Ye Zhang <ye.zhang@...k-chips.com>
Cc: linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
 tao.huang@...k-chips.com, finley.xiao@...k-chips.com,
 tim.chen@...k-chips.com, elaine.zhang@...k-chips.com,
 Ye Zhang <ye.zhang@...k-chips.com>
Subject: Re: [PATCH v2] gpio: rockchip: avoid division by zero

Am Freitag, 23. August 2024, 05:43:04 CEST schrieb Ye Zhang:
> If the clk_get_rate return '0', it will happen division by zero.
> 
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Ye Zhang <ye.zhang@...k-chips.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/gpio/gpio-rockchip.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index 0bd339813110..712258224eb3 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -207,6 +207,8 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc,
>  	if (bank->gpio_type == GPIO_TYPE_V2 && !IS_ERR(bank->db_clk)) {
>  		div_debounce_support = true;
>  		freq = clk_get_rate(bank->db_clk);
> +		if (!freq)
> +			return -EINVAL;
>  		max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq;
>  		if (debounce > max_debounce)
>  			return -EINVAL;
>