linux-kernel - RE: [PATCH v2] mm/vmstat: Defer the refresh_zone_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYZP153MB0796B44322EAE4C712883201BE882@TYZP153MB0796.APCP153.PROD.OUTLOOK.COM>
Date: Fri, 23 Aug 2024 09:32:26 +0000
From: Saurabh Singh Sengar <ssengar@...rosoft.com>
To: Saurabh Singh Sengar <ssengar@...rosoft.com>, Saurabh Sengar
	<ssengar@...ux.microsoft.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "wei.liu@...nel.org" <wei.liu@...nel.org>, "srivatsa@...il.mit.edu"
	<srivatsa@...il.mit.edu>, "mgorman@...hsingularity.net"
	<mgorman@...hsingularity.net>, "cl@...ux.com" <cl@...ux.com>
Subject: RE: [PATCH v2] mm/vmstat: Defer the refresh_zone_stat_thresholds
 after all CPUs bringup



> -----Original Message-----
> From: Saurabh Singh Sengar <ssengar@...rosoft.com>
> Sent: 23 August 2024 15:00
> To: Saurabh Sengar <ssengar@...ux.microsoft.com>; akpm@...ux-
> foundation.org; linux-mm@...ck.org; linux-kernel@...r.kernel.org
> Cc: wei.liu@...nel.org; srivatsa@...il.mit.edu; clameter@....com;
> mgorman@...hsingularity.net
> Subject: [EXTERNAL] RE: [PATCH v2] mm/vmstat: Defer the
> refresh_zone_stat_thresholds after all CPUs bringup
> 
> 
> 
> > -----Original Message-----
> > From: Saurabh Sengar <ssengar@...ux.microsoft.com>
> > Sent: 12 August 2024 11:44
> > To: akpm@...ux-foundation.org; linux-mm@...ck.org; linux-
> > kernel@...r.kernel.org
> > Cc: Saurabh Singh Sengar <ssengar@...rosoft.com>; wei.liu@...nel.org;
> > srivatsa@...il.mit.edu
> > Subject: [PATCH v2] mm/vmstat: Defer the refresh_zone_stat_thresholds
> > after all CPUs bringup
> >
> > refresh_zone_stat_thresholds function has two loops which is expensive
> > for higher number of CPUs and NUMA nodes.
> >
> > Below is the rough estimation of total iterations done by these loops
> > based on number of NUMA and CPUs.
> >
> > Total number of iterations: nCPU * 2 * Numa * mCPU
> > Where:
> >  nCPU = total number of CPUs
> >  Numa = total number of NUMA nodes
> >  mCPU = mean value of total CPUs (e.g., 512 for 1024 total CPUs)
> >
> > For the system under test with 16 NUMA nodes and 1024 CPUs, this
> > results in a substantial increase in the number of loop iterations
> > during boot-up when NUMA is enabled:
> >
> > No NUMA = 1024*2*1*512  =   1,048,576 : Here
> refresh_zone_stat_thresholds
> > takes around 224 ms total for all the CPUs in the system under test.
> > 16 NUMA = 1024*2*16*512 =  16,777,216 : Here
> > refresh_zone_stat_thresholds takes around 4.5 seconds total for all
> > the CPUs in the system under test.
> >
> > Calling this for each CPU is expensive when there are large number of
> > CPUs along with multiple NUMAs. Fix this by deferring
> > refresh_zone_stat_thresholds to be called later at once when all the
> > secondary CPUs are up. Also, register the DYN hooks to keep the
> > existing hotplug functionality intact.
> >
> > Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> 
> CC: Mel Gorman and Christoph Lameter


Adding cl@...ux.com instead of clameter@....com for Christoph Lameter

- Saurabh