[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240823110824.3895787-1-yanzhen@vivo.com>
Date: Fri, 23 Aug 2024 19:08:24 +0800
From: Yan Zhen <yanzhen@...o.com>
To: vigneshr@...com,
miquel.raynal@...tlin.com,
richard@....at
Cc: linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org,
opensource.kernel@...o.com,
Yan Zhen <yanzhen@...o.com>
Subject: [PATCH v2] mtd: concat: Use kmemdup_array instead of kmemdup for multiple allocation
When we are allocating an array, using kmemdup_array() to take care about
multiplication and possible overflows.
Also it makes auditing the code easier.
Signed-off-by: Yan Zhen <yanzhen@...o.com>
---
Changes in v2:
- Rewrite the patch title and the patch description
drivers/mtd/mtdconcat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index 193428de6a4b..f56f44aa8625 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -204,7 +204,7 @@ concat_writev(struct mtd_info *mtd, const struct kvec *vecs,
}
/* make a copy of vecs */
- vecs_copy = kmemdup(vecs, sizeof(struct kvec) * count, GFP_KERNEL);
+ vecs_copy = kmemdup_array(vecs, count, sizeof(struct kvec), GFP_KERNEL);
if (!vecs_copy)
return -ENOMEM;
--
2.34.1
Powered by blists - more mailing lists