[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240823124033.00007f76@Huawei.com>
Date: Fri, 23 Aug 2024 12:40:33 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Santosh Shilimkar <ssantosh@...nel.org>, Krzysztof Kozlowski
<krzk@...nel.org>, Roger Quadros <rogerq@...nel.org>, Tony Lindgren
<tony@...mide.com>, Vladimir Zapolskiy <vz@...ia.com>, Miquel Raynal
<miquel.raynal@...tlin.com>, Michal Simek <michal.simek@....com>,
<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/7] memory: emif: simplify locking with guard()
On Fri, 23 Aug 2024 12:15:57 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> Simplify error handling (less gotos) over locks with guard().
>
> The driver used file-scope variable 'irq_state' for storing IRQ state
> with spin_lock_irqsave, so move it into respective local scopes. This
> should be equivalent, but more readable (less global variables).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
LGTM. File scoped irq_state is certainly unusual...
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...ei.com>
Powered by blists - more mailing lists