linux-kernel - Re: [PATCH v3 07/10] drm/tegra: gr3d: Convert into devm_pm_domain_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kg3gfmh4vd5lgnglk7wzzullu7s3b7lpnh3czinmvpds2it7cm@bowytsfbzzvi>
Date: Fri, 23 Aug 2024 13:53:28 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>, 
	Stephen Boyd <sboyd@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <quic_kdybcio@...cinc.com>, Nikunj Kela <nkela@...cinc.com>, 
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Mikko Perttunen <mperttunen@...dia.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Stephan Gerhold <stephan@...hold.net>, 
	Ilia Lin <ilia.lin@...nel.org>, Stanimir Varbanov <stanimir.k.varbanov@...il.com>, 
	Vikash Garodia <quic_vgarodia@...cinc.com>, linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 07/10] drm/tegra: gr3d: Convert into
 devm_pm_domain_attach_list()

On Fri, Aug 23, 2024 at 12:45:44AM GMT, Ulf Hansson wrote:
> Rather than hooking up the PM domains through devm_pm_opp_attach_genpd()
> and manage the device-link, let's avoid the boilerplate-code by converting
> into devm_pm_domain_attach_list().
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
> 
> Changes in v3:
> 	- Updated commitmsg.
> 	- Converted to devm mangaged version of dev_pm_domain_attach_list()
> 
> ---
>  drivers/gpu/drm/tegra/gr3d.c | 38 +++++++-----------------------------
>  1 file changed, 7 insertions(+), 31 deletions(-)

I'm not very familiar with most of the OPP bits in this driver, but it
looks like the corresponding code is now in the core, so this seems
fine:

Acked-by: Thierry Reding <treding@...dia.com>

On a related note: we have two other case on Tegra where we attach to
multiple PM domains (drivers/usb/host/xhci-tegra.c and
drivers/usb/gadget/udc/tegra-xudc.c). Both of those don't use OPP, but
I wonder if they could also be simplified using the new
devm_pm_domain_attach_list() function?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)