lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dbc462ac55944c3ae82b07937b194673e61df626.camel@kernel.org>
Date: Fri, 23 Aug 2024 08:06:20 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Li Lingfeng <lilingfeng3@...wei.com>, trondmy@...nel.org,
 anna@...nel.org,  chuck.lever@...cle.com, neilb@...e.de, kolga@...app.com,
 Dai.Ngo@...cle.com,  tom@...pey.com
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yukuai1@...weicloud.com, houtao1@...wei.com, yi.zhang@...wei.com, 
	yangerkun@...wei.com, lilingfeng@...weicloud.com
Subject: Re: [PATCH 1/4] nfsd: fix the comment of nfs_get_root

On Fri, 2024-08-23 at 15:00 +0800, Li Lingfeng wrote:
> The comment for nfs_get_root() needs to be updated as it would also be
> used by NFS4 as follows:
> @x[
>     nfs_get_root+1
>     nfs_get_tree_common+1819
>     nfs_get_tree+2594
>     vfs_get_tree+73
>     fc_mount+23
>     do_nfs4_mount+498
>     nfs4_try_get_tree+134
>     nfs_get_tree+2562
>     vfs_get_tree+73
>     path_mount+2776
>     do_mount+226
>     __se_sys_mount+343
>     __x64_sys_mount+106
>     do_syscall_64+69
>     entry_SYSCALL_64_after_hwframe+97
> , mount.nfs4]: 1
> 
> Signed-off-by: Li Lingfeng <lilingfeng3@...wei.com>
> ---
>  fs/nfs/getroot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/getroot.c b/fs/nfs/getroot.c
> index 11ff2b2e060f..f13d25d95b85 100644
> --- a/fs/nfs/getroot.c
> +++ b/fs/nfs/getroot.c
> @@ -62,7 +62,7 @@ static int nfs_superblock_set_dummy_root(struct super_block *sb, struct inode *i
>  }
>  
>  /*
> - * get an NFS2/NFS3 root dentry from the root filehandle
> + * get a root dentry from the root filehandle
>   */
>  int nfs_get_root(struct super_block *s, struct fs_context *fc)
>  {

Note that this is a NFS client patch, not a nfsd patch like the title
suggests.

Acked-by: Jeff Layton <jlayton@...nel.org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ