[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <808caff5016c82b338dc46b2a855732dae79d5ba.camel@kernel.org>
Date: Fri, 23 Aug 2024 08:08:33 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Li Lingfeng <lilingfeng3@...wei.com>, trondmy@...nel.org,
anna@...nel.org, chuck.lever@...cle.com, neilb@...e.de, kolga@...app.com,
Dai.Ngo@...cle.com, tom@...pey.com
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
yukuai1@...weicloud.com, houtao1@...wei.com, yi.zhang@...wei.com,
yangerkun@...wei.com, lilingfeng@...weicloud.com
Subject: Re: [PATCH 3/4] nfsd: remove the redundant blank line
On Fri, 2024-08-23 at 15:00 +0800, Li Lingfeng wrote:
> Just remove the redundant blank line in do_open_permission. No function
> change.
>
> Signed-off-by: Li Lingfeng <lilingfeng3@...wei.com>
> ---
> fs/nfsd/nfs4proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 2e39cf2e502a..0068db924060 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -141,7 +141,6 @@ fh_dup2(struct svc_fh *dst, struct svc_fh *src)
> static __be32
> do_open_permission(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_open *open, int accmode)
> {
> -
> if (open->op_truncate &&
> !(open->op_share_access & NFS4_SHARE_ACCESS_WRITE))
> return nfserr_inval;
NACK. In general, we don't take whitespace patches. They just make
backporting harder later if you have to do it. If you have a material
change to make in this area, then go ahead and fix the whitespace, but
otherwise don't bother.
--
Jeff Layton <jlayton@...nel.org>
Powered by blists - more mailing lists