linux-kernel - Re: [PATCH v2] gpio: rockchip: release reference to device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70b6e321-0b8d-4dd1-b098-4cb6a0f83f93@rock-chips.com>
Date: Fri, 23 Aug 2024 18:52:29 +0800
From: Shawn Lin <shawn.lin@...k-chips.com>
To: Ye Zhang <ye.zhang@...k-chips.com>, linus.walleij@...aro.org,
 brgl@...ev.pl, heiko@...ech.de, linux-gpio@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: shawn.lin@...k-chips.com, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, mika.westerberg@...ux.intel.com,
 andriy.shevchenko@...ux.intel.com, tao.huang@...k-chips.com,
 finley.xiao@...k-chips.com, tim.chen@...k-chips.com,
 elaine.zhang@...k-chips.com
Subject: Re: [PATCH v2] gpio: rockchip: release reference to device node

在 2024/8/23 11:43, Ye Zhang 写道:
> Added a call to of_node_put(pctlnp) in rockchip_gpio_probe to properly
> release the reference to the device node, improving memory management
> and preventing potential leaks.
> 
> Fixes: 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
> Signed-off-by: Ye Zhang <ye.zhang@...k-chips.com>

Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>

> ---
>   drivers/gpio/gpio-rockchip.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index 712258224eb3..5f60162baaeb 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -715,6 +715,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
>   		return -ENODEV;
>   
>   	pctldev = of_pinctrl_get(pctlnp);
> +	of_node_put(pctlnp);
>   	if (!pctldev)
>   		return -EPROBE_DEFER;
>