linux-kernel - Re: [PATCH -next] spi: wpcm-fiu: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zsh9UA4iXvMzm2HW@probook>
Date: Fri, 23 Aug 2024 14:15:12 +0200
From: J. Neuschäfer <j.neuschaefer@....net>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: j.neuschaefer@....net, broonie@...nel.org, openbmc@...ts.ozlabs.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] spi: wpcm-fiu: Use
 devm_platform_ioremap_resource_byname()

On Tue, Aug 20, 2024 at 08:35:18PM +0800, Jinjie Ruan wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

Looks good to me, thanks!

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@....net>

> ---
>  drivers/spi/spi-wpcm-fiu.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-wpcm-fiu.c b/drivers/spi/spi-wpcm-fiu.c
> index 886d6d7771d4..47e485fd8f84 100644
> --- a/drivers/spi/spi-wpcm-fiu.c
> +++ b/drivers/spi/spi-wpcm-fiu.c
> @@ -448,8 +448,7 @@ static int wpcm_fiu_probe(struct platform_device *pdev)
>  	fiu = spi_controller_get_devdata(ctrl);
>  	fiu->dev = dev;
>
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "control");
> -	fiu->regs = devm_ioremap_resource(dev, res);
> +	fiu->regs = devm_platform_ioremap_resource_byname(pdev, "control");
>  	if (IS_ERR(fiu->regs)) {
>  		dev_err(dev, "Failed to map registers\n");
>  		return PTR_ERR(fiu->regs);
> @@ -459,8 +458,7 @@ static int wpcm_fiu_probe(struct platform_device *pdev)
>  	if (IS_ERR(fiu->clk))
>  		return PTR_ERR(fiu->clk);
>
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "memory");
> -	fiu->memory = devm_ioremap_resource(dev, res);
> +	fiu->memory = devm_platform_ioremap_resource_byname(pdev, "memory");
>  	fiu->memory_size = min_t(size_t, resource_size(res), MAX_MEMORY_SIZE_TOTAL);
>  	if (IS_ERR(fiu->memory)) {
>  		dev_err(dev, "Failed to map flash memory window\n");
> --
> 2.34.1
>