linux-kernel - Re: [RFC PATCH v3 33/37] kvx: Add support for cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888f5510-5404-4daf-8683-5f43d810f4ee@kalrayinc.com>
Date: Fri, 23 Aug 2024 15:00:11 +0200
From: Yann Sionneau <ysionneau@...rayinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org
Cc: Jonathan Borne <jborne@...rayinc.com>, Julian Vetter
 <jvetter@...rayinc.com>, Clement Leger <clement@...ment-leger.fr>, Guillaume
 Thouvenin <thouveng@...il.com>, Jules Maselbas <jmaselbas@...v.net>
Subject: Re: [RFC PATCH v3 33/37] kvx: Add support for cpuinfo

Hello Krzysztof

On 22/07/2024 14:35, Krzysztof Kozlowski wrote:
> On 22/07/2024 11:41, ysionneau@...rayinc.com wrote:
>> From: Yann Sionneau <ysionneau@...rayinc.com>
>>
>> Add support for cpuinfo on kvx arch.
[...]
>> +
>> +static void c_stop(struct seq_file *m, void *v)
>> +{
>> +}
>> +
>> +const struct seq_operations cpuinfo_op = {
> Where is this used?

This is used by `fs/proc/cpuinfo.c`: https://elixir.bootlin.com/linux/v6.10.6/source/fs/proc/cpuinfo.c#L12

I think I should add a #ifdef CONFIG_PROC_FS around this code, or even better use obj-$(CONFIG_PROC_FS) in the Makefile

>
>> +	.start = c_start,
>> +	.next = c_next,
>> +	.stop = c_stop,
>> +	.show = show_cpuinfo,
>> +};
>> +

-- 

Yann