linux-kernel - Re: [PATCH net] net: mana: Fix race of mana_hwc_post_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172441982778.2965533.12833287131080058770.git-patchwork-notify@kernel.org>
Date: Fri, 23 Aug 2024 13:30:27 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, decui@...rosoft.com,
 stephen@...workplumber.org, kys@...rosoft.com, paulros@...rosoft.com,
 olaf@...fle.de, vkuznets@...hat.com, davem@...emloft.net, wei.liu@...nel.org,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, leon@...nel.org,
 longli@...rosoft.com, ssengar@...ux.microsoft.com,
 linux-rdma@...r.kernel.org, daniel@...earbox.net, john.fastabend@...il.com,
 bpf@...r.kernel.org, ast@...nel.org, hawk@...nel.org, tglx@...utronix.de,
 shradhagupta@...ux.microsoft.com, jesse.brandeburg@...el.com,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] net: mana: Fix race of mana_hwc_post_rx_wqe and new hwc
 response

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Wed, 21 Aug 2024 13:42:29 -0700 you wrote:
> The mana_hwc_rx_event_handler() / mana_hwc_handle_resp() calls
> complete(&ctx->comp_event) before posting the wqe back. It's
> possible that other callers, like mana_create_txq(), start the
> next round of mana_hwc_send_request() before the posting of wqe.
> And if the HW is fast enough to respond, it can hit no_wqe error
> on the HW channel, then the response message is lost. The mana
> driver may fail to create queues and open, because of waiting for
> the HW response and timed out.
> Sample dmesg:
> [  528.610840] mana 39d4:00:02.0: HWC: Request timed out!
> [  528.614452] mana 39d4:00:02.0: Failed to send mana message: -110, 0x0
> [  528.618326] mana 39d4:00:02.0 enP14804s2: Failed to create WQ object: -110
> 
> [...]

Here is the summary with links:
  - [net] net: mana: Fix race of mana_hwc_post_rx_wqe and new hwc response
    https://git.kernel.org/netdev/net/c/8af174ea863c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html