linux-kernel - Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsiXCqNOs0dHF379@pengutronix.de>
Date: Fri, 23 Aug 2024 16:04:58 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Stefan Eichenberger <eichest@...il.com>
Cc: Andi Shyti <andi.shyti@...nel.org>, kernel@...gutronix.de,
	shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com,
	Frank.Li@....com, francesco.dolcini@...adex.com,
	linux-i2c@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Stefan Eichenberger <stefan.eichenberger@...adex.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master
 mode

On Fri, Aug 23, 2024 at 03:48:32PM +0200, Stefan Eichenberger wrote:
> Hi Andi,
> 
> On Fri, Aug 23, 2024 at 02:35:54AM +0200, Andi Shyti wrote:
> > Hi,
> > 
> > On Thu, Aug 22, 2024 at 12:04:43PM GMT, Oleksij Rempel wrote:
> > > On Thu, Aug 22, 2024 at 09:03:55AM +0200, Stefan Eichenberger wrote:
> > > > Hi Andi,
> > > > 
> > > > On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote:
> > > > > Hi Stefan,
> > > > > 
> > > > > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
> > > > > >  		goto rpm_disable;
> > > > > >  	}
> > > > > >  
> > > > > > +	i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master");
> > > > > > +
> > > > > 
> > > > > you might also want to add the multi-master boolean property in
> > > > > the binding.
> > > > 
> > > > We discussed this internally and weren't sure when it was required
> > > > because e.g. i2c-rcar and i2c-tegra don't have it documented in their
> > > > bindings. Is it still required if it is part of the dt-schema?
> > > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml
> > > 
> > > The i2c-imx.yaml has "unevaluatedProperties: false", which fill discard
> > > every thing not in this yaml
> > > 
> > > > If so, I will add it in the next version.
> > > 
> > > Yes, please.
> > 
> > sorry for the confusion, please don't add it. I had a chat with
> > Krzysztof and I will quote him: "this is a core property, coming
> > with dtschema, so they dont need to update bindings".
> > 
> > He also sent a cleanup to remove the only binding using it.
> 
> No problem, thanks for the clarification. 
> 
> Should I still separate the multi-master patch from the rest of the
> series, even though it doesn't seem to fix the problem Fabio sees? I did
> some more testing today and the workarounds he found do not solve the
> problem I see, so they are definitely not the same.

I'll try to review your DMA patches next week.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |