[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <595a4009-ba70-44c1-b5a1-7a692624e196@kernel.org>
Date: Sat, 24 Aug 2024 08:21:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Karthikeyan Krishnasamy <karthikeyan@...umiz.com>, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de,
alexandre.belloni@...tlin.com
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rtc@...r.kernel.org
Subject: Re: [PATCH 2/8] ARM: dts: rockchip: Add i2s0 node for RV1126
On 23/08/2024 17:35, Karthikeyan Krishnasamy wrote:
> Add i2s0 node and possible pinctrl for Rockchip RV1126
>
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@...umiz.com>
> ---
> .../arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 102 ++++++++++++++++++
> arch/arm/boot/dts/rockchip/rv1126.dtsi | 26 +++++
> 2 files changed, 128 insertions(+)
...
> + i2s0m1_sdo1_sdi3: i2s0m1-sdo1_sdi3 {
> + rockchip,pins =
> + /* i2s0_sdo1_sdi3_m1 */
> + <3 RK_PB3 3 &pcfg_pull_none>;
> + };
> + i2s0m1_sdo2_sdi2: i2s0m1-sdo2_sdi2 {
> + rockchip,pins =
> + /* i2s0_sdo2_sdi2_m1 */
> + <3 RK_PB4 3 &pcfg_pull_none>;
Weird alignment...
> + };
> + i2s0m1_sdo3_sdi1: i2s0m1-sdo3_sdi1 {
No underscores in node names,
> + rockchip,pins =
> + /* i2s0_sdo3_sdi1_m1 */
> + <3 RK_PB5 3 &pcfg_pull_none>;
> + };
> + };
Best regards,
Krzysztof
Powered by blists - more mailing lists