linux-kernel - Re: [PATCH next 1/2] dt-bindings: net: bluetooth: nxp: support multiple init baudrates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6he2msn6oj74isl4l3b2ivegfh6sf5rvqo6cqpcmoqrnvonka4@kesvvmd45l7i>
Date: Sat, 24 Aug 2024 08:30:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: amitkumar.karwar@....com, neeraj.sanjaykale@....com, 
	marcel@...tmann.org, luiz.dentz@...il.com, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	bsp-development.geo@...ca-geosystems.com, customers.leicageo@...gutronix.de
Subject: Re: [PATCH next 1/2] dt-bindings: net: bluetooth: nxp: support
 multiple init baudrates

On Fri, Aug 23, 2024 at 02:42:38PM +0200, Catalin Popescu wrote:
> Make "fw-init-baudrate" a list of baudrates in order to support chips
> using different baudrates assuming that we could not detect the
> supported baudrate otherwise.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml  | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 37a65badb448..42e3713927de 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -25,11 +25,12 @@ properties:
>  
>    fw-init-baudrate:
>      $ref: /schemas/types.yaml#/definitions/uint32
> +    maxItems: 8
>      default: 115200
>      description:
> -      Chip baudrate after FW is downloaded and initialized.
> -      This property depends on the module vendor's
> -      configuration.
> +      List of chip baudrates after FW is downloaded and initialized.
> +      The driver goes through the list until it founds a working baudrate.
> +      This property depends on the module vendor's configuration.
>  

You need to test your patch... and update the example and explain why
changing from 1 to 8 items (so ABI break) is okay or needed.

But even without updating the example, you would see errors when testing
DTS, so this was never tested. :/

Best regards,
Krzysztof