linux-kernel - Re: [PATCH v2 07/12] dt-bindings: mmc: Add support for rk3576 eMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m5ua5jnbv4u36glqt2qrps35asuqfycxedgjrfhodi5bvs2r2h@xvy4qxt4gx74>
Date: Sat, 24 Aug 2024 09:49:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	Andi Shyti <andi.shyti@...nel.org>, Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Lee Jones <lee@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Mark Brown <broonie@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>, 
	Guenter Roeck <linux@...ck-us.net>, Chris Morgan <macromorgan@...mail.com>, 
	Jonas Karlman <jonas@...boo.se>, Tim Lunn <tim@...thertop.org>, Chukun Pan <amadeus@....edu.cn>, 
	Andy Yan <andyshrk@....com>, Muhammed Efe Cetin <efectn@...tonmail.com>, 
	Jagan Teki <jagan@...eble.ai>, Dragan Simic <dsimic@...jaro.org>, Ondrej Jirman <megi@....cz>, 
	Michael Riesch <michael.riesch@...fvision.net>, Jimmy Hon <honyuenkwun@...il.com>, 
	Alexey Charkov <alchark@...il.com>, Elon Zhang <zhangzj@...k-chips.com>, 
	Elaine Zhang <zhangqing@...k-chips.com>, Yifeng Zhao <yifeng.zhao@...k-chips.com>, 
	Finley Xiao <finley.xiao@...k-chips.com>, Liang Chen <cl@...k-chips.com>, 
	Jisheng Zhang <jszhang@...nel.org>, Jamie Iles <jamie@...ieiles.com>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	dri-devel@...ts.freedesktop.org, linux-i2c@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-mmc@...r.kernel.org, linux-serial@...r.kernel.org, linux-spi@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v2 07/12] dt-bindings: mmc: Add support for rk3576 eMMC

On Fri, Aug 23, 2024 at 10:52:34AM -0400, Detlev Casanova wrote:
> The device is compatible with rk3588, so add an entry for the 2
> compatibles together.
> 
> The rk3576 device has a power-domain that needs to be on for the eMMC to
> be used. Add it as a requirement.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---
>  .../bindings/mmc/snps,dwcmshc-sdhci.yaml      | 32 +++++++++++++------
>  1 file changed, 23 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 4d3031d9965f3..7d5e388587027 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -12,16 +12,29 @@ maintainers:
>  
>  allOf:
>    - $ref: mmc-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3576-dwcmshc
> +    then:
> +      properties:
> +        power-domains:
> +          minItems: 1

Plaese move the allOf: after the required: block. It grows too much with
such if:then: and that's not the most important part of binding we need
to see first.

With above change:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof