| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202408241510.Rk14q8Rg-lkp@intel.com>
Date: Sat, 24 Aug 2024 16:04:21 +0800
From: kernel test robot <lkp@...el.com>
To: Jiaxun Yang <jiaxun.yang@...goat.com>, Rob Herring <robh@...nel.org>,
Saravana Kannan <saravanak@...gle.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
loongarch@...ts.linux.dev, chenhuacai@...nel.org,
Kevin Wheatfox <enkerewpo@...mail.com>,
Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH] of_reserved_mem: Save region name string into struct
reserved_mem
Hi Jiaxun,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bb1b0acdcd66e0d8eedee3570d249e076b89ab32]
url: https://github.com/intel-lab-lkp/linux/commits/Jiaxun-Yang/of_reserved_mem-Save-region-name-string-into-struct-reserved_mem/20240821-215235
base: bb1b0acdcd66e0d8eedee3570d249e076b89ab32
patch link: https://lore.kernel.org/r/20240821-save_resv_name-v1-1-b9c17f103ffb%40flygoat.com
patch subject: [PATCH] of_reserved_mem: Save region name string into struct reserved_mem
config: i386-buildonly-randconfig-002-20240824 (https://download.01.org/0day-ci/archive/20240824/202408241510.Rk14q8Rg-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240824/202408241510.Rk14q8Rg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408241510.Rk14q8Rg-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/of/of_reserved_mem.c:467:12: warning: address of array 'rmem->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
467 | rmem->name ? rmem->name : "unknown");
| ~~~~~~^~~~ ~
include/linux/printk.h:538:34: note: expanded from macro 'pr_info'
538 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:465:60: note: expanded from macro 'printk'
465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
437 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
1 warning generated.
vim +467 drivers/of/of_reserved_mem.c
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 426
3f0c8206644836 Marek Szyprowski 2014-02-28 427 /**
c8813f7ec01c67 chenqiwu 2020-05-11 428 * fdt_init_reserved_mem() - allocate and init all saved reserved memory regions
3f0c8206644836 Marek Szyprowski 2014-02-28 429 */
3f0c8206644836 Marek Szyprowski 2014-02-28 430 void __init fdt_init_reserved_mem(void)
3f0c8206644836 Marek Szyprowski 2014-02-28 431 {
3f0c8206644836 Marek Szyprowski 2014-02-28 432 int i;
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 433
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 434 /* check for overlapping reserved regions */
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 435 __rmem_check_for_overlap();
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 436
3f0c8206644836 Marek Szyprowski 2014-02-28 437 for (i = 0; i < reserved_mem_count; i++) {
3f0c8206644836 Marek Szyprowski 2014-02-28 438 struct reserved_mem *rmem = &reserved_mem[i];
3f0c8206644836 Marek Szyprowski 2014-02-28 439 unsigned long node = rmem->fdt_node;
3f0c8206644836 Marek Szyprowski 2014-02-28 440 int err = 0;
6f1188b4ac7577 Yue Hu 2020-07-30 441 bool nomap;
3f0c8206644836 Marek Szyprowski 2014-02-28 442
d0b8ed47e83a22 pierre Kuo 2019-02-19 443 nomap = of_get_flat_dt_prop(node, "no-map", NULL) != NULL;
9dcfee01930e6c Marek Szyprowski 2014-07-14 444
3f0c8206644836 Marek Szyprowski 2014-02-28 445 if (rmem->size == 0)
3f0c8206644836 Marek Szyprowski 2014-02-28 446 err = __reserved_mem_alloc_size(node, rmem->name,
3f0c8206644836 Marek Szyprowski 2014-02-28 447 &rmem->base, &rmem->size);
d0b8ed47e83a22 pierre Kuo 2019-02-19 448 if (err == 0) {
d0b8ed47e83a22 pierre Kuo 2019-02-19 449 err = __reserved_mem_init_node(rmem);
d0b8ed47e83a22 pierre Kuo 2019-02-19 450 if (err != 0 && err != -ENOENT) {
d0b8ed47e83a22 pierre Kuo 2019-02-19 451 pr_info("node %s compatible matching fail\n",
d0b8ed47e83a22 pierre Kuo 2019-02-19 452 rmem->name);
d0b8ed47e83a22 pierre Kuo 2019-02-19 453 if (nomap)
7b25995f5319ad Dong Aisheng 2021-06-11 454 memblock_clear_nomap(rmem->base, rmem->size);
3c6867a12a224d Dong Aisheng 2021-06-11 455 else
3ecc68349bbab6 Mike Rapoport 2021-11-05 456 memblock_phys_free(rmem->base,
3ecc68349bbab6 Mike Rapoport 2021-11-05 457 rmem->size);
aeb9267eb6b1df Martin Liu 2023-02-10 458 } else {
aeb9267eb6b1df Martin Liu 2023-02-10 459 phys_addr_t end = rmem->base + rmem->size - 1;
aeb9267eb6b1df Martin Liu 2023-02-10 460 bool reusable =
aeb9267eb6b1df Martin Liu 2023-02-10 461 (of_get_flat_dt_prop(node, "reusable", NULL)) != NULL;
aeb9267eb6b1df Martin Liu 2023-02-10 462
6ee7afbabcee4d Geert Uytterhoeven 2023-02-16 463 pr_info("%pa..%pa (%lu KiB) %s %s %s\n",
aeb9267eb6b1df Martin Liu 2023-02-10 464 &rmem->base, &end, (unsigned long)(rmem->size / SZ_1K),
aeb9267eb6b1df Martin Liu 2023-02-10 465 nomap ? "nomap" : "map",
aeb9267eb6b1df Martin Liu 2023-02-10 466 reusable ? "reusable" : "non-reusable",
aeb9267eb6b1df Martin Liu 2023-02-10 @467 rmem->name ? rmem->name : "unknown");
d0b8ed47e83a22 pierre Kuo 2019-02-19 468 }
d0b8ed47e83a22 pierre Kuo 2019-02-19 469 }
3f0c8206644836 Marek Szyprowski 2014-02-28 470 }
3f0c8206644836 Marek Szyprowski 2014-02-28 471 }
9dcfee01930e6c Marek Szyprowski 2014-07-14 472
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists