linux-kernel - Re: [PATCH] padata: use integer wrap around to prevent deadlock on seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsnjMWrFP0IYJmaa@gondor.apana.org.au>
Date: Sat, 24 Aug 2024 21:42:09 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: VanGiang Nguyen <vangiang.nguyen@...de-schwarz.com>
Cc: steffen.klassert@...unet.com, daniel.m.jordan@...cle.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] padata: use integer wrap around to prevent deadlock on
 seq_nr overflow

VanGiang Nguyen <vangiang.nguyen@...de-schwarz.com> wrote:
> When submitting more than 2^32 padata objects to padata_do_serial, the
> current sorting implementation incorrectly sorts padata objects with
> overflowed seq_nr, causing them to be placed before existing objects in
> the reorder list. This leads to a deadlock in the serialization process
> as padata_find_next cannot match padata->seq_nr and pd->processed
> because the padata instance with overflowed seq_nr will be selected
> next.
> 
> To fix this, we use an unsigned integer wrap around to correctly sort
> padata objects in scenarios with integer overflow.
> 
> Co-developed-by: Christian Gafert <christian.gafert@...de-schwarz.com>
> Signed-off-by: Christian Gafert <christian.gafert@...de-schwarz.com>
> Co-developed-by: Max Ferger <max.ferger@...de-schwarz.com>
> Signed-off-by: Max Ferger <max.ferger@...de-schwarz.com>
> Signed-off-by: Van Giang Nguyen <vangiang.nguyen@...de-schwarz.com>
> ---
> kernel/padata.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt