linux-kernel - Re: [PATCH v8 2/4] kbuild: generate offset range data for builtin modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=PNDOYo8kwscy0Sup6g3qfffFsSJMssJh_jGb3D4JzcA@mail.gmail.com>
Date: Sat, 24 Aug 2024 18:44:24 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: Kris Van Hees <kris.van.hees@...cle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org, 
	linux-modules@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	Nick Alcock <nick.alcock@...cle.com>, Alan Maguire <alan.maguire@...cle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Masahiro Yamada <masahiroy@...nel.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Jiri Olsa <olsajiri@...il.com>, 
	Elena Zannoni <elena.zannoni@...cle.com>
Subject: Re: [PATCH v8 2/4] kbuild: generate offset range data for builtin modules

On Fri, Aug 23, 2024 at 7:24 PM Sami Tolvanen <samitolvanen@...gle.com> wrote:
>
> I assume they wanted to avoid conflicts between Rust-specific
> environment variables and existing Kbuild variables. Note that
> KBUILD_MODFILE is also double quoted for the C preprocessor, which
> isn't needed for Rust. Miguel, do you remember if there's another
> reason for the different variable name?

No, I don't recall another reason -- I think you are right, they did
not carry (exactly) the same contents, and thus the different name.

So I think it can be merged/changed into something else if needed.

Cheers,
Miguel