linux-kernel - Re: [RESEND PATCH] arm64: dts: ti: k3-j722s-evm: Add support for multiple CAN instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240824174337.lixnpedg24qaroxs@headed>
Date: Sat, 24 Aug 2024 12:43:37 -0500
From: Nishanth Menon <nm@...com>
To: Bhavya Kapoor <b-kapoor@...com>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <conor+dt@...nel.org>,
        <krzk+dt@...nel.org>, <robh@...nel.org>, <kristo@...nel.org>,
        <jm@...com>, <vigneshr@...com>
Subject: Re: [RESEND PATCH] arm64: dts: ti: k3-j722s-evm: Add support for
 multiple CAN instances

On 13:50-20240808, Bhavya Kapoor wrote:
> CAN instances 0 and 1 in the mcu domain and 0 in the main domain are
> brought on the evm through headers J5, J8 and J10 respectively. Thus,
> add their respective transceiver's 0, 1 and 2 dt nodes as well as
> add the required pinmux to add support for these CAN instances.
> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@...com>
> Reviewed-by: Judith Mendez <jm@...com>
[...]

> +&main_mcan0 {
> +	status = "okay";

NAK: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_mcan0_pins_default>;
> +	phys = <&transceiver2>;
> +};
> +
> +&mcu_gpio0 {
> +	status = "okay";
> +};
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D