linux-kernel - Re: [PATCH net-next] net: liquidio: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240825081820.GW2164@kernel.org>
Date: Sun, 25 Aug 2024 09:18:20 +0100
From: Simon Horman <horms@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: liquidio: Remove unused declarations

On Sat, Aug 24, 2024 at 04:31:07PM +0800, Yue Haibing wrote:
> Commit da15c78b5664 ("liquidio CN23XX: VF register access") declared
> cn23xx_dump_vf_initialized_regs() but never implemented it.
> 
> octeon_dump_soft_command() is never implemented and used since introduction in
> commit 35878618c92d ("liquidio: Added delayed work for periodically updating
> the link statistics.").
> 
> And finally, a few other declarations were never implenmented since introduction
> in commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters").
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Thanks, I looked over the git history of this driver
and agree with the analysis above.

Reviewed-by: Simon Horman <horms@...nel.org>