linux-kernel - Re: [PATCH v3] x86/cpu: Adjust the error message when BIOS does not support SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cc1f0a0a4cb03007d52c040c05bf77f2fa16d6d.camel@intel.com>
Date: Sun, 25 Aug 2024 08:49:22 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "seanjc@...gle.com" <seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "hpa@...or.com"
	<hpa@...or.com>, "wangyuli@...ontech.com" <wangyuli@...ontech.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com"
	<mingo@...hat.com>, "xiangzelong@...ontech.com" <xiangzelong@...ontech.com>
CC: "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
	"jarkko@...nel.org" <jarkko@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
	"bp@...e.de" <bp@...e.de>, "guanwentao@...ontech.com"
	<guanwentao@...ontech.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "sean.j.christopherson@...el.com"
	<sean.j.christopherson@...el.com>, "haitao.huang@...ux.intel.com"
	<haitao.huang@...ux.intel.com>, "wubo@...ontech.com" <wubo@...ontech.com>
Subject: Re: [PATCH v3] x86/cpu: Adjust the error message when BIOS does not
 support SGX

On Sun, 2024-08-25 at 16:17 +0800, WangYuli wrote:
> When SGX is not supported by the BIOS, the kernel log still output
> the error 'SGX disabled by BIOS', which can be confusing since
> there might not be an SGX-related option in the BIOS settings.
> 
> As a kernel, it's difficult to distinguish between the BIOS not
> supporting SGX and the BIOS supporting SGX but it's disabled.
> 
> Therefore, update the error message to
> 'SGX disabled or unsupported by BIOS' to make it easier for those
> reading kernel logs to understand what's happening.
> 
> Reported-by: Bo Wu <wubo@...ontech.com>
> Closes: https://github.com/linuxdeepin/developer-center/issues/10032
> Acked-by: Kai Huang <kai.huang@...el.com>
> Link: https://lore.kernel.org/all/a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com/
> Signed-off-by: Zelong Xiang <xiangzelong@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

Hi Yuli,

When Thomas pointed out the "Signed-off-by chain is invalid" in v2:

https://lore.kernel.org/all/87zfpx4a0q.ffs@tglx/T/#mdc19b00c10177f3add9deaf505211bf8b3ec7110

I think it meant you either need to have a Co-developed-by for Zelong Xiang,
or you should remove his/her SoB.  The reason is the patch is from you, but
not Zelong.

The SoB chain needs to reflect the chronological history of this patch.  E.g.,
the SoB chain:

	From: You
	Co-developed-by: Zelong
	Signed-off-by: Zelong
	Signed-off-by: You

.. means the patch was originally generated by you, but Zelong also
participated in developing this patch before you finally signed off it.

For this one line code change patch, it doesn't make a lot sense to have
multiple developers, so I think you can just remove Zelong's SoB.