linux-kernel - Re: [PATCH v2] X86 architecture (32-bit and 64-bit): Convert to use jiffies macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6b8g81i.ffs@tglx>
Date: Sun, 25 Aug 2024 13:23:53 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Chen Yufan <chenyufan@...o.com>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Chen Yufan
 <chenyufan@...o.com>, Stephen Rothwell <sfr@...b.auug.org.au>,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v2] X86 architecture (32-bit and 64-bit): Convert to use
 jiffies macro

On Thu, Aug 22 2024 at 16:24, Chen Yufan wrote:
> Use time_after macro instead of using
> jiffies directly to handle wraparound.
>
> Signed-off-by: Chen Yufan <chenyufan@...o.com>
>
> The modifications made compared to the previous version are as follows:

Please put such version information below the --- separator so tools can
strip it off when applying the patch, which avoids editiong

> 1. Remove extra '+' in the header.

The subject line still has a incorrect subsystem prefix:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

Also 'use jiffies macro' is not really informative. Something like

     "Use time_after() for jiffies comparison"

makes it entirely clear what this is about.

> Use time_after macro instead of using
> jiffies directly to handle wraparound.

Also here instead of 'time_after macro' please use simply
'time_after()'. It's uninteresting whether this is a macro or not.

Thanks,

        tglx