linux-kernel - Re: [PATCH] crypto: sa2ul - fix memory leak in sa_cra_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ttf8n7i4.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sun, 25 Aug 2024 17:23:39 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Ma Ke <make24@...as.ac.cn>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <t-kristo@...com>, <j-keerthy@...com>
CC: <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ma Ke
	<make24@...as.ac.cn>, <stable@...r.kernel.org>
Subject: Re: [PATCH] crypto: sa2ul - fix memory leak in sa_cra_init_aead()

Ma Ke <make24@...as.ac.cn> writes:

> Currently the resource allocated by crypto_alloc_shash() is not freed in
> case crypto_alloc_aead() fails, resulting in memory leak.
>
> Add crypto_free_shash() to fix it.
>
> Found by code review.
>
> Cc: stable@...r.kernel.org
> Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
LGTM.

Reviewed-by: Kamlesh Gurudasani <kamlesh@...com>