linux-kernel - Re: [PATCH] Revert "memory: ti-aemif: don't needlessly iterate over child nodes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172458853245.37697.15563719161583396830.b4-ty@linaro.org>
Date: Sun, 25 Aug 2024 14:22:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, 
 Santosh Shilimkar <ssantosh@...nel.org>, 
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-kernel@...r.kernel.org, 
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] Revert "memory: ti-aemif: don't needlessly iterate
 over child nodes"


On Sat, 24 Aug 2024 10:02:35 +0200, Bartosz Golaszewski wrote:
> This reverts commit 23a641d5c2bce4c723fff9118a5d865ee6b9d05a.
> 
> The first-level children of the aemif node are not the device nodes (ones
> containing the 'compatible' property) but the chip-select nodes which
> instead have their own children.
> 
> of_platform_populate() will skip such nodes so we must indeed iterate
> over the direct children of the aemif node. The problem here is that we
> never call of_platform_depopulate() as it takes the root device as
> argument. We only have an unpopulated chip-select nodes so we will leak
> these devices if any of the calls to of_platform_populate() fails.
> 
> [...]

Applied, thanks!

[1/1] Revert "memory: ti-aemif: don't needlessly iterate over child nodes"
      https://git.kernel.org/krzk/linux-mem-ctrl/c/c7d2f3fbdf59b206414ddc306b0fb74cd174c0ed

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>