linux-kernel - [tip: x86/cleanups] x86/cpu: Clarify the error message when BIOS does not support SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172458996487.2215.5672971101697733211.tip-bot2@tip-bot2>
Date: Sun, 25 Aug 2024 12:46:04 -0000
From: "tip-bot2 for WangYuli" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Bo Wu <wubo@...ontech.com>, Zelong Xiang <xiangzelong@...ontech.com>,
 WangYuli <wangyuli@...ontech.com>, Thomas Gleixner <tglx@...utronix.de>,
 Kai Huang <kai.huang@...el.com>, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip: x86/cleanups] x86/cpu: Clarify the error message when BIOS does
 not support SGX

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     7678a53a1688e3d03337ca884b284c6e7b060ec5
Gitweb:        https://git.kernel.org/tip/7678a53a1688e3d03337ca884b284c6e7b060ec5
Author:        WangYuli <wangyuli@...ontech.com>
AuthorDate:    Sun, 25 Aug 2024 18:46:53 +08:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Sun, 25 Aug 2024 14:41:19 +02:00

x86/cpu: Clarify the error message when BIOS does not support SGX

When SGX is not supported by the BIOS, the kernel log contains the error
'SGX disabled by BIOS', which can be confusing since there might not be an
SGX-related option in the BIOS settings.

For the kernel it's difficult to distinguish between the BIOS not
supporting SGX and the BIOS supporting SGX but having it disabled.

Therefore, update the error message to 'SGX disabled or unsupported by
BIOS' to make it easier for those reading kernel logs to understand what's
happening.

Reported-by: Bo Wu <wubo@...ontech.com>
Co-developed-by: Zelong Xiang <xiangzelong@...ontech.com>
Signed-off-by: Zelong Xiang <xiangzelong@...ontech.com>
Signed-off-by: WangYuli <wangyuli@...ontech.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Acked-by: Kai Huang <kai.huang@...el.com>
Link: https://lore.kernel.org/all/F8D977CB368423F3+20240825104653.1294624-1-wangyuli@uniontech.com
Closes: https://github.com/linuxdeepin/developer-center/issues/10032
---
 arch/x86/kernel/cpu/feat_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/feat_ctl.c b/arch/x86/kernel/cpu/feat_ctl.c
index 1640ae7..4a41187 100644
--- a/arch/x86/kernel/cpu/feat_ctl.c
+++ b/arch/x86/kernel/cpu/feat_ctl.c
@@ -188,7 +188,7 @@ update_caps:
 update_sgx:
 	if (!(msr & FEAT_CTL_SGX_ENABLED)) {
 		if (enable_sgx_kvm || enable_sgx_driver)
-			pr_err_once("SGX disabled by BIOS.\n");
+			pr_err_once("SGX disabled or unsupported by BIOS.\n");
 		clear_cpu_cap(c, X86_FEATURE_SGX);
 		return;
 	}