linux-kernel - Re: [PATCH 1/3] pmdomain: imx93-pd: replace dev_err() with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cd324a7-1a08-47ca-9729-a5d680ca0589@wanadoo.fr>
Date: Sun, 25 Aug 2024 15:40:20 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: linux-amarula@...rulasolutions.com, Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>, Peng Fan <peng.fan@....com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/3] pmdomain: imx93-pd: replace dev_err() with
 dev_err_probe()

Le 25/08/2024 à 14:36, Dario Binacchi a écrit :
> This way, the code becomes more compact, and dev_err_probe() is used in
> every error path of the probe() function.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> ---
> 
>   drivers/pmdomain/imx/imx93-pd.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pmdomain/imx/imx93-pd.c b/drivers/pmdomain/imx/imx93-pd.c
> index d750a7dc58d2..afc482ec563f 100644
> --- a/drivers/pmdomain/imx/imx93-pd.c
> +++ b/drivers/pmdomain/imx/imx93-pd.c
> @@ -126,9 +126,9 @@ static int imx93_pd_probe(struct platform_device *pdev)
>   	if (!domain->init_off) {
>   		ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks);
>   		if (ret) {
> -			dev_err(domain->dev, "failed to enable clocks for domain: %s\n",
> -				domain->genpd.name);
> -			return ret;
> +			return dev_err_probe(domain->dev, ret,
> +					     "failed to enable clocks for domain: %s\n",
> +					     domain->genpd.name);
>   		}

Hi,

you can now also remove the extra { } to be even more compact.

CJ

>   	}
>