linux-kernel - Re: [PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240825142509.201943-1-amadeus@jmu.edu.cn>
Date: Sun, 25 Aug 2024 22:25:09 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: detlev.casanova@...labora.com
Cc: airlied@...il.com,
	alchark@...il.com,
	amadeus@....edu.cn,
	andi.shyti@...nel.org,
	andyshrk@....com,
	broonie@...nel.org,
	cl@...k-chips.com,
	conor+dt@...nel.org,
	daniel@...ll.ch,
	devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	dsimic@...jaro.org,
	efectn@...tonmail.com,
	finley.xiao@...k-chips.com,
	gregkh@...uxfoundation.org,
	heiko@...ech.de,
	honyuenkwun@...il.com,
	jagan@...eble.ai,
	jamie@...ieiles.com,
	jic23@...nel.org,
	jirislaby@...nel.org,
	jonas@...boo.se,
	jszhang@...nel.org,
	kernel@...labora.com,
	krzk+dt@...nel.org,
	lars@...afoo.de,
	lee@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-i2c@...r.kernel.org,
	linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	linux-serial@...r.kernel.org,
	linux-spi@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	linux@...ck-us.net,
	maarten.lankhorst@...ux.intel.com,
	macromorgan@...mail.com,
	megi@....cz,
	michael.riesch@...fvision.net,
	mripard@...nel.org,
	robh@...nel.org,
	tim@...thertop.org,
	tzimmermann@...e.de,
	ulf.hansson@...aro.org,
	wim@...ux-watchdog.org
Subject: Re: [PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

Hi,

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> ...
> +	leds: leds {
> +		compatible = "gpio-leds";

Maybe there should be a blank line.

> +		work_led: work-led {
> +			gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};

Is the color missing?

> ...
> +	vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_3v3_rtc_s5";
> +		regulator-boot-on;
> +		regulator-always-on;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vcc_5v0_sys>;
> +	};

Missing blank line.

> +	vcc_1v8_s0: regulator-vcc-1v8-s0 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_1v8_s0";
> +		regulator-boot-on;
> +		regulator-always-on;
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&vcc_1v8_s3>;
> +	};
> ...
> +&gmac0 {
> +	phy-mode = "rgmii-rxid";

Can we use "rgmii-id" and remove tx_delay here?

> ...
> +&sdmmc {
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	cap-sd-highspeed;
> +	disable-wp;
> +	max-frequency = <200000000>;
> +	no-sdio;
> +	no-mmc;
> +	non-removable;
> +	sd-uhs-sdr104;
> +        vmmc-supply = <&vcc_3v3_s3>;

Indentation error.

> +	vqmmc-supply = <&vccio_sd_s0>;
> +	status = "okay";
> +};
> ...

Thanks,
Chukun

-- 
2.25.1