linux-kernel - Re: [PATCH] staging: rtl8192e: Fix multiple assignments in rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <324c34e3-3471-4cbe-aa6d-b14244ca48eb@gmail.com>
Date: Sun, 25 Aug 2024 19:43:16 -0300
From: Alien Wesley <alienwesley51@...il.com>
To: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix multiple assignments in
 rtl_wx.c:529

Sorry folks, this was supposed to be a v2.
[PATCH v2] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: multiple assignments should be avoided.
>
> ---
> Changes in v2:
>      - Removed two spaces in front of "=".
>
> Signed-off-by: Alien Wesley <alienwesley51@...il.com>
> ---
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..67c4793e0fc1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
>   	mutex_unlock(&priv->wx_mutex);
>   
>   	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
> -		ieee->pairwise_key_type  = KEY_TYPE_NA;
> +		ieee->pairwise_key_type = KEY_TYPE_NA;
>   		ieee->group_key_type = KEY_TYPE_NA;
>   		rtl92e_cam_reset(dev);
>   		memset(priv->rtllib->swcamtable, 0,