linux-kernel - Re: [PATCH 5.15 000/479] 5.15.165-rc3 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <135ef4fd-4fc9-40b4-b188-8e64946f47c4@roeck-us.net>
Date: Sun, 25 Aug 2024 18:04:13 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org
Cc: patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
 torvalds@...ux-foundation.org, akpm@...ux-foundation.org, shuah@...nel.org,
 patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
 jonathanh@...dia.com, f.fainelli@...il.com, sudipm.mukherjee@...il.com,
 srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
 allen.lkml@...il.com, broonie@...nel.org,
 Jiaxun Yang <jiaxun.yang@...goat.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 5.15 000/479] 5.15.165-rc3 review

On 8/17/24 01:00, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.165 release.
> There are 479 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Mon, 19 Aug 2024 07:51:05 +0000.
> Anything received after that time might be too late.
> 
[ ... ]
> Jiaxun Yang <jiaxun.yang@...goat.com>
>      MIPS: Loongson64: reset: Prioritise firmware service
> 

This patch in v5.15.165 results in:

Building mips:loongson2k_defconfig ... failed
--------------
Error log:
arch/mips/loongson64/reset.c:25:36: error: 'struct sys_off_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
    25 | static int firmware_restart(struct sys_off_data *unusedd)
       |                                    ^~~~~~~~~~~~
arch/mips/loongson64/reset.c:34:37: error: 'struct sys_off_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
    34 | static int firmware_poweroff(struct sys_off_data *unused)
       |                                     ^~~~~~~~~~~~
arch/mips/loongson64/reset.c: In function 'mips_reboot_setup':
arch/mips/loongson64/reset.c:144:17: error: implicit declaration of function 'register_sys_off_handler'; did you mean 'register_restart_handler'? [-Werror=implicit-function-declaration]
   144 |                 register_sys_off_handler(SYS_OFF_MODE_RESTART,
       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
       |                 register_restart_handler
arch/mips/loongson64/reset.c:144:42: error: 'SYS_OFF_MODE_RESTART' undeclared (first use in this function)
   144 |                 register_sys_off_handler(SYS_OFF_MODE_RESTART,
       |                                          ^~~~~~~~~~~~~~~~~~~~
arch/mips/loongson64/reset.c:144:42: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/loongson64/reset.c:145:34: error: 'SYS_OFF_PRIO_FIRMWARE' undeclared (first use in this function)
   145 |                                  SYS_OFF_PRIO_FIRMWARE,
       |                                  ^~~~~~~~~~~~~~~~~~~~~
arch/mips/loongson64/reset.c:150:42: error: 'SYS_OFF_MODE_POWER_OFF' undeclared (first use in this function); did you mean 'SYSTEM_POWER_OFF'?
   150 |                 register_sys_off_handler(SYS_OFF_MODE_POWER_OFF,
       |                                          ^~~~~~~~~~~~~~~~~~~~~~
       |                                          SYSTEM_POWER_OFF

This is not entirely surprising since the missing functions and defines
do not exist in v5.15.y.

Guenter