linux-kernel - Re: [PATCH] drm/etnaviv: Use unsigned type to count the number of userspace pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH9NwWeVFtOuQ=6dpXotrR-BGMjYAo3-fR6CHgcHbOxiZ87xCA@mail.gmail.com>
Date: Mon, 26 Aug 2024 16:23:26 +0200
From: Christian Gmeiner <christian.gmeiner@...il.com>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>
Cc: Lucas Stach <l.stach@...gutronix.de>, Russell King <linux+etnaviv@...linux.org.uk>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, etnaviv@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/etnaviv: Use unsigned type to count the number of
 userspace pages

>
> The unpin_user_pages() function takes an unsigned long argument to store
> length of the number of user space pages, and struct drm_gem_object::size
> is a size_t type. The number of pages can not be negative, hence, use an
> unsigned variable to store the number of pages.
>
> Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>

Reviewed-by: Christian Gmeiner <cgmeiner@...lia.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index ce9c9233c4a6..fa0d193cec26 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -695,7 +695,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)
>                 kfree(etnaviv_obj->sgt);
>         }
>         if (etnaviv_obj->pages) {
> -               int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> +               unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
>
>                 unpin_user_pages(etnaviv_obj->pages, npages);
>                 kvfree(etnaviv_obj->pages);
> --
> 2.34.1
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy