linux-kernel - Re: [PATCH] perf hist: Don't set hpp_fmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsySQ9MADfhrABFy@x1>
Date: Mon, 26 Aug 2024 11:33:39 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: kan.liang@...ux.intel.com, irogers@...gle.com, peterz@...radead.org,
	mingo@...nel.org, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf hist: Don't set hpp_fmt_value for members in
 --no-group

On Wed, Aug 21, 2024 at 05:38:45PM -0700, Namhyung Kim wrote:
> Hi Kan,
> 
> On Tue, Aug 20, 2024 at 11:31 AM <kan.liang@...ux.intel.com> wrote:
> >
> > From: Kan Liang <kan.liang@...ux.intel.com>
> >
> > Perf crashes as below when applying --no-group
> >
> > perf record -e "{cache-misses,branches"} -b sleep 1
> > perf report --stdio --no-group
> > free(): invalid next size (fast)
> > Aborted (core dumped)
> >
> > In the __hpp__fmt(), only 1 hpp_fmt_value is allocated for the current
> > event when --no-group is applied. However, the current implementation
> > tries to assign the hists from all members to the hpp_fmt_value, which
> > exceeds the allocated memory.
> >
> > Fixes: 8f6071a3dce4 ("perf hist: Simplify __hpp_fmt() using hpp_fmt_data")
> > Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied to perf-tools-next,

- Arnaldo