linux-kernel - Re: [PATCH 2/5] reset: k210: fix OF node leak in probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afad6db5-e33c-4402-adec-d1948300191a@kernel.org>
Date: Mon, 26 Aug 2024 13:11:39 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Antoine Tenart <atenart@...nel.org>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Palmer Dabbelt <palmerdabbelt@...gle.com>, Vladimir Zapolskiy <vz@...ia.com>
Cc: linux-kernel@...r.kernel.org, Damien Le Moal <damien.lemoal@....com>,
 linux-riscv@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/5] reset: k210: fix OF node leak in probe() error path

On 8/25/24 11:14 PM, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference on memory allocation failure.
> Acquire the OF node reference after memory allocation to fix this and
> keep it simple.
> 
> Fixes: 5a2308da9f60 ("riscv: Add Canaan Kendryte K210 reset controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research