| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2986a485-935d-4ab2-9a16-4a85288aa15a@camlingroup.com> Date: Mon, 26 Aug 2024 17:42:01 +0200 From: Lech Perczak <lech.perczak@...lingroup.com> To: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Hugo Villeneuve <hvilleneuve@...onoff.com>, Andy Shevchenko <andy@...nel.org>, Krzysztof Drobiński <k.drobinski@...lintechnologies.com>, Pawel Lenkow <p.lenkow@...lintechnologies.com>, Kirill Yatsenko <kirill.yatsenko@...lingroup.com> Subject: [PATCH v4 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which don't match the datasheet - fix them. At the same time remove comments for individual constants, as they add nothing to the definitions themselves. Signed-off-by: Lech Perczak <lech.perczak@...lingroup.com> --- Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Jiri Slaby <jirislaby@...nel.org> Cc: Hugo Villeneuve <hvilleneuve@...onoff.com> Cc: Andy Shevchenko <andy@...nel.org> --- drivers/tty/serial/sc16is7xx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..36b7c682ae94 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -266,9 +266,9 @@ * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) /* SWFLOW bit 3 */ -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) /* SWFLOW bit 2 - * +#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) +#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) + /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow * control @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 - * - * SWFLOW bits 3 & 2 table: +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) + /* + * SWFLOW bits 1 & 0 table: * 00 -> no received flow * control * 01 -> receiver compares -- 2.34.1
Powered by blists - more mailing lists