linux-kernel - [PATCH] lib: glob.c: added null check for character class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240826155709.12383-1-swaminathanalok@gmail.com>
Date: Mon, 26 Aug 2024 11:57:09 -0400
From: Alok Swaminathan <swaminathanalok@...il.com>
To: akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org,
	Alok Swaminathan <swaminathanalok@...il.com>
Subject: [PATCH] lib: glob.c: added null check for character class

Added null check for character class. Previously, an inverted character 
class could result in a nul byte being matched and lead to the function 
reading past the end of the inputted str.

Signed-off-by: Alok Swaminathan <swaminathanalok@...il.com>
---
 lib/glob.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/glob.c b/lib/glob.c
index 15b73f490720..aa57900d2062 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -68,6 +68,8 @@ bool __pure glob_match(char const *pat, char const *str)
 			back_str = --str;	/* Allow zero-length match */
 			break;
 		case '[': {	/* Character class */
+			if (c == '\0')	/* No possible match */
+				return false;
 			bool match = false, inverted = (*pat == '!');
 			char const *class = pat + inverted;
 			unsigned char a = *class++;
-- 
2.46.0