linux-kernel - Re: [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsytxXE/4Binsl26@lizhi-Precision-Tower-5810>
Date: Mon, 26 Aug 2024 12:31:01 -0400
From: Frank Li <Frank.li@....com>
To: miquel.raynal@...tlin.com, vkoul@...nel.org
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org,
	dmaengine@...r.kernel.org, festevam@...il.com, han.xu@....com,
	imx@...ts.linux.dev, kernel@...gutronix.de, krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mtd@...ts.infradead.org, marex@...x.de, richard@....at,
	robh@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org,
	vigneshr@...com
Subject: Re: [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible
 string "fsl,imx8qxp-dma-apbh"

On Thu, Aug 01, 2024 at 05:46:01PM -0400, Frank Li wrote:
> Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> compared with "fsl,imx28-dma-apbh".
>
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
>
> Keep the same restriction about 'power-domains' for other compatible
> strings.
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---

vkoul:

    Could you please take care this patch?

Frank

> Change from v2 to v3
> - Add rob's review tag
> - resend because it is dropped from mtd tree at
> https://lore.kernel.org/imx/20240717103846.306bf9fd@xps-13/
> ---
>  .../devicetree/bindings/dma/fsl,mxs-dma.yaml      | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> index add9c77e8b52a..a17cf2360dd4a 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> @@ -11,6 +11,17 @@ maintainers:
>
>  allOf:
>    - $ref: dma-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8qxp-dma-apbh
> +    then:
> +      required:
> +        - power-domains
> +    else:
> +      properties:
> +        power-domains: false
>
>  properties:
>    compatible:
> @@ -20,6 +31,7 @@ properties:
>                - fsl,imx6q-dma-apbh
>                - fsl,imx6sx-dma-apbh
>                - fsl,imx7d-dma-apbh
> +              - fsl,imx8qxp-dma-apbh
>            - const: fsl,imx28-dma-apbh
>        - enum:
>            - fsl,imx23-dma-apbh
> @@ -42,6 +54,9 @@ properties:
>    dma-channels:
>      enum: [4, 8, 16]
>
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> --
> 2.34.1
>