linux-kernel - [PATCH net 0/4] mptcp: close subflow when receiving TCP+FIN and misc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240826-net-mptcp-close-extra-sf-fin-v1-0-905199fe1172@kernel.org>
Date: Mon, 26 Aug 2024 19:11:17 +0200
From: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
To: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>, 
 Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, Florian Westphal <fw@...len.de>, 
 Shuah Khan <shuah@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-kselftest@...r.kernel.org, 
 "Matthieu Baerts (NGI0)" <matttbe@...nel.org>, stable@...r.kernel.org
Subject: [PATCH net 0/4] mptcp: close subflow when receiving TCP+FIN and
 misc.

Here are different fixes:

Patch 1 closes the subflow after having received a FIN, instead of
leaving it half-closed until the end of the MPTCP connection. A fix for
v5.12.

Patch 2 validates the previous patch.

Patch 3 is a fix for a recent fix to check both directions for the
backup flag. It can follow the 'Fixes' commit and be backported up to
v5.7.

Patch 4 adds a missing \n at the end of pr_debug(), causing debug
messages to be displayed with a delay, which confuses the debugger. A
fix for v5.6.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
---
Note: Peter's email address has been removed from the Cc list, because
it is bouncing.

---
Matthieu Baerts (NGI0) (4):
      mptcp: close subflow when receiving TCP+FIN
      selftests: mptcp: join: cannot rm sf if closed
      mptcp: sched: check both backup in retrans
      mptcp: pr_debug: add missing \n at the end

 net/mptcp/fastopen.c                            |  4 +-
 net/mptcp/options.c                             | 50 ++++++++++-----------
 net/mptcp/pm.c                                  | 28 ++++++------
 net/mptcp/pm_netlink.c                          | 20 ++++-----
 net/mptcp/protocol.c                            | 59 +++++++++++++------------
 net/mptcp/protocol.h                            |  4 +-
 net/mptcp/sched.c                               |  4 +-
 net/mptcp/sockopt.c                             |  4 +-
 net/mptcp/subflow.c                             | 56 ++++++++++++-----------
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ++---
 10 files changed, 122 insertions(+), 118 deletions(-)
---
base-commit: 31a972959ae57691a1e4f539399b2674ae576086
change-id: 20240826-net-mptcp-close-extra-sf-fin-19d4e5aa4c9c

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@...nel.org>