linux-kernel - Re: [PATCH v2 1/6] ACPI: ac: Use strscpy() instead of strcpy().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h72S=9mMWOx=mh+A4jJKHBKX_cEetk1fpi0c9VH_df8g@mail.gmail.com>
Date: Mon, 26 Aug 2024 19:14:49 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] ACPI: ac: Use strscpy() instead of strcpy().

On Sun, Aug 4, 2024 at 2:34 PM Muhammad Qasim Abdul Majeed
<qasim.majeed20@...il.com> wrote:
>
> Replace strcpy() with strscpy() in the ACPI ac driver.
> strcpy() has been deprecated because it is generally unsafe, so help to
> eliminate it from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
>
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
> ---
>  drivers/acpi/ac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 09a87fa222c7..ad1427a384e4 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>
>         ac->device = adev;
> -       strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> -       strcpy(acpi_device_class(adev), ACPI_AC_CLASS);
> +       strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> +       strscpy(acpi_device_class(adev), ACPI_AC_CLASS);
>
>         platform_set_drvdata(pdev, ac);
>
> --

Applied as 6.12 material with some subject and changelog edits along
with patches [2-4/6] and [6/6].

Patch [6/6] needs more work (I'll send a reply to it directly).

Thanks!