linux-kernel - Re: [PATCH] acpi video: force native for Apple MacbookPro9,2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iJ5+USjDpSY1zKwboiqGm=GUL1BRBTasvND1Tp99R4fQ@mail.gmail.com>
Date: Mon, 26 Aug 2024 19:25:14 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Hans de Goede <hdegoede@...hat.com>, Esther Shimanovich <eshimanovich@...omium.org>
Cc: Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi video: force native for Apple MacbookPro9,2

On Wed, Aug 7, 2024 at 12:25 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 8/6/24 10:08 PM, Esther Shimanovich wrote:
> > It used to be that the MacbookPro9,2 used its native intel backlight
> > device until the following commit was introduced:
> > commit b1d36e73cc1c ("drm/i915: Don't register backlight when another
> > backlight should be used (v2)")
> > This commit forced this model to use its firmware acpi_video backlight
> > device instead.
> >
> > That worked fine until an additional commit was added:
> > commit 92714006eb4d ("drm/i915/backlight: Do not bump min brightness
> > to max on enable")
> > That commit uncovered a bug in the MacbookPro 9,2's acpi_video
> > backlight firmware; the backlight does not come back up after resume.
> >
> > Add DMI quirk to select the working native intel interface instead
> > so that the backlight successfully comes back up after resume.
> >
> > Signed-off-by: Esther Shimanovich <eshimanovich@...omium.org>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Applied as 6.12 material with some minor edits in the subject and changelog.

Thanks!


> > ---
> >  drivers/acpi/video_detect.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> > index c11cbe5b6eaa..2d377414f873 100644
> > --- a/drivers/acpi/video_detect.c
> > +++ b/drivers/acpi/video_detect.c
> > @@ -547,6 +547,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> >               DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),
> >               },
> >       },
> > +     {
> > +      .callback = video_detect_force_native,
> > +      /* Apple MacBook Pro 9,2 */
> > +      .matches = {
> > +             DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> > +             DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro9,2"),
> > +             },
> > +     },
> >       {
> >        /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
> >        .callback = video_detect_force_native,
> >
> > ---
> > base-commit: d9ef02e56f0fd3668b6d7cb17f9399ea53f12edd
> > change-id: 20240806-acpi-video-quirk-f1c9f01f07d9
> >
> > Best regards,
>
>