linux-kernel - Re: [PATCH v7 0/3] drm: Use full allocated minor range for DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b313a6f7-a857-4ec9-bc98-0480cd64bc20@amd.com>
Date: Mon, 26 Aug 2024 20:07:43 +0200
From: Christian König <christian.koenig@....com>
To: Michał Winiarski <michal.winiarski@...el.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org
Cc: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Simon Ser <contact@...rsion.fr>, Matthew Wilcox <willy@...radead.org>,
 Oded Gabbay <ogabbay@...nel.org>, James Zhu <James.Zhu@....com>,
 Pekka Paalanen <pekka.paalanen@...labora.com>,
 Emil Velikov <emil.l.velikov@...il.com>, Alex Deucher <alexdeucher@...il.com>
Subject: Re: [PATCH v7 0/3] drm: Use full allocated minor range for DRM

Am 23.08.24 um 18:30 schrieb Michał Winiarski:
> 64 DRM device nodes is not enough for everyone.
> Upgrade it to ~512K (which definitely is more than enough).
>
> Additionally, convert minors to use XArray instead of IDR to simplify
> the locking.
>
> Corresponding libdrm changes were merged in:
> https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305

Added my Acked-by and pushed the result to drm-misc-next.

Regards,
Christian.

>
> v1 -> v2:
> Don't touch DRM_MINOR_CONTROL and its range (Simon Ser)
>
> v2 -> v3:
> Don't use legacy scheme for >=192 minor range (Dave Airlie)
> Add modparam for testing (Dave Airlie)
> Add lockdep annotation for IDR (Daniel Vetter)
>
> v3 -> v4:
> Convert from IDR to XArray (Matthew Wilcox)
>
> v4 -> v5:
> Fixup IDR to XArray conversion (Matthew Wilcox)
>
> v5 -> v6:
> Also convert Accel to XArray
> Rename skip_legacy_minors to force_extended_minors
>
> v6 -> v7:
> Drop the force_extended_minors patch intended for debug
> Rebase on latest drm-tip
> Update the cover letter, pointing out libdrm changes
>
> Michał Winiarski (3):
>    drm: Use XArray instead of IDR for minors
>    accel: Use XArray instead of IDR for minors
>    drm: Expand max DRM device number to full MINORBITS
>
>   drivers/accel/drm_accel.c      | 110 +++------------------------------
>   drivers/gpu/drm/drm_drv.c      |  97 ++++++++++++++---------------
>   drivers/gpu/drm/drm_file.c     |   2 +-
>   drivers/gpu/drm/drm_internal.h |   4 --
>   include/drm/drm_accel.h        |  18 +-----
>   include/drm/drm_file.h         |   5 ++
>   6 files changed, 62 insertions(+), 174 deletions(-)
>