linux-kernel - Re: [PATCH v3] staging: rtl8192e: Fix multiple assignments in rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240826182029.ZFtqcPCP@linutronix.de>
Date: Mon, 26 Aug 2024 20:20:29 +0200
From: Nam Cao <namcao@...utronix.de>
To: Alien Wesley <alienwesley51@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH v3] staging: rtl8192e: Fix multiple assignments in
 rtl_wx.c:529

On Mon, Aug 26, 2024 at 01:28:04PM -0300, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
> 
> CHECK: multiple assignments should be avoided.
> 
> Signed-off-by: Alien Wesley <alienwesley51@...il.com>
> ---
> v3: Fix typo in commit message.
> v2: Removed two spaces in front of "=".
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..67c4793e0fc1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
>  	mutex_unlock(&priv->wx_mutex);
>  
>  	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
> -		ieee->pairwise_key_type  = KEY_TYPE_NA;
> +		ieee->pairwise_key_type = KEY_TYPE_NA;

I was completely confused, because the desscription says "Fix multiple
assignments", yet I only see a whitespace fix.

So I looked at v1, and it makes sense, you are sending this as a follow-up
fix for a double-space issue that you added in v1.

Instead of doing this, please just squash your v1 and v3 patches together
and send it as v4. This v3 patch doesn't make sense on its own.

Best regards,
Nam