linux-kernel - Re: [PATCH] fuse: remove useless IOCB_DIRECT in fuse_direct_read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegt_P=Dj-CXnbZYK+XZW8ZwNH0_Str30q9vub0o00UMuWQ@mail.gmail.com>
Date: Mon, 26 Aug 2024 21:12:39 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: yangyun <yangyun50@...wei.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lixiaokeng@...wei.com
Subject: Re: [PATCH] fuse: remove useless IOCB_DIRECT in fuse_direct_read/write_iter

On Mon, 26 Aug 2024 at 15:07, yangyun <yangyun50@...wei.com> wrote:
>
> Commit 23c94e1cdcbf ("fuse: Switch to using async direct IO
> for FOPEN_DIRECT_IO") gave the async direct IO code path in the
> fuse_direct_read_iter() and fuse_direct_write_iter(). But since
> these two functions are only called under FOPEN_DIRECT_IO is set,
> it seems that we can also use the async direct IO even the flag
> IOCB_DIRECT is not set to enjoy the async direct IO method. Also
> move the definition of fuse_io_priv to where it is used in fuse_
> direct_write_iter.

I'm interested in the motivation for this patch.

There's a minor risk of regressions when introducing such a behavior
change, so there should also be a strong supporting argument, which
seems to be missing in this case.

Thanks,
Miklos