linux-kernel - Re: [PATCH v2 -next 09/11] cgroup/cpuset: move v1 interfaces to cpuset-v1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZszaJFzcmBskojVS@slm.duckdns.org>
Date: Mon, 26 Aug 2024 09:40:20 -1000
From: Tejun Heo <tj@...nel.org>
To: Waiman Long <longman@...hat.com>
Cc: Chen Ridong <chenridong@...wei.com>, lizefan.x@...edance.com,
	hannes@...xchg.org, adityakali@...gle.com, sergeh@...nel.org,
	mkoutny@...e.com, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, chenridong@...weicloud.com
Subject: Re: [PATCH v2 -next 09/11] cgroup/cpuset: move v1 interfaces to
 cpuset-v1.c

On Mon, Aug 26, 2024 at 03:30:14PM -0400, Waiman Long wrote:
...
> Another alternative is to include cpuset-v1.c directly into cpuset.c like
> 
> #ifdef CONFIG_CPUSETS_V1
> #include "cpuset-v1.c"
> #else
>    ....
> #endif
> 
> Then you don't need to change the names and will not need cpuset-internal.h.
> It is up to you to decide what you want to do.

FWIW, I'd prefer to have cpuset1_ prefixed functions declared in cpuset1.h
or something rather than including .c file.

Thanks.

-- 
tejun