linux-kernel - Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D3Q3WI8AHRJ1.3B8E985JAVVC2@cknow.org>
Date: Mon, 26 Aug 2024 21:56:34 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Detlev Casanova" <detlev.casanova@...labora.com>, "Chukun Pan"
 <amadeus@....edu.cn>
Cc: <airlied@...il.com>, <alchark@...il.com>, <andi.shyti@...nel.org>,
 <andyshrk@....com>, <broonie@...nel.org>, <cl@...k-chips.com>,
 <conor+dt@...nel.org>, <daniel@...ll.ch>, <devicetree@...r.kernel.org>,
 <dri-devel@...ts.freedesktop.org>, <dsimic@...jaro.org>,
 <efectn@...tonmail.com>, <finley.xiao@...k-chips.com>,
 <gregkh@...uxfoundation.org>, <heiko@...ech.de>, <honyuenkwun@...il.com>,
 <jagan@...eble.ai>, <jamie@...ieiles.com>, <jic23@...nel.org>,
 <jirislaby@...nel.org>, <jonas@...boo.se>, <jszhang@...nel.org>,
 <kernel@...labora.com>, <krzk+dt@...nel.org>, <lars@...afoo.de>,
 <lee@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-i2c@...r.kernel.org>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-serial@...r.kernel.org>,
 <linux-spi@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
 <linux@...ck-us.net>, <maarten.lankhorst@...ux.intel.com>,
 <macromorgan@...mail.com>, <megi@....cz>, <michael.riesch@...fvision.net>,
 <mripard@...nel.org>, <robh@...nel.org>, <tim@...thertop.org>,
 <tzimmermann@...e.de>, <ulf.hansson@...aro.org>, <wim@...ux-watchdog.org>
Subject: Re: [PATCH v2 11/12] arm64: dts: rockchip: Add rk3576 SoC base DT

On Mon Aug 26, 2024 at 8:28 PM CEST, Detlev Casanova wrote:
> On Sunday, 25 August 2024 10:08:24 EDT Chukun Pan wrote:
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> > > ...
> > > +		opp-1416000000 {
> > > +			opp-hz = /bits/ 64 <1416000000>;
> > > +			opp-microvolt = <725000 725000 950000>;
> > > +			opp-microvolt-L1 = <712500 712500 950000>;
> > > +			opp-microvolt-L2 = <700000 700000 950000>;
> > > +			opp-microvolt-L3 = <700000 700000 950000>;
> > > +			opp-microvolt-L4 = <700000 700000 950000>;
> > > +			opp-microvolt-L5 = <700000 700000 950000>;
> > > +			clock-latency-ns = <40000>;
> > > +		};
> > > ...
> > 
> > I'm curious if these frequencies work properly. On the bsp kernel,
> > 'opp-microvolt-L<name>' is used by the PVTM driver, I don't know
> > if it works on the upstream kernel.
>
> Which seems to correspond to the set opp-hz value. As mentionned by Alexey, 
> the opp-microvolt-L.* values are not used by the driver.
>
> I also have not tested any cpufreq settings/driver on this board yet. I can 
> remove the opp-microvolt-L.* for now.

If you run this command on the upstream kernel:
``grep -r "opp-microvolt" arch/arm64/boot/dts/rockchip/``

you'll see it doesn't use the opp-microvolt-LN variants anywhere,
so this is indeed a downstream/BSP only thing.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)