linux-kernel - Re: [PATCH] affs: Remove unused struct members in affs_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408261307.F7D2AD650@keescook>
Date: Mon, 26 Aug 2024 13:08:05 -0700
From: Kees Cook <kees@...nel.org>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: dsterba@...e.com, gustavoars@...nel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] affs: Remove unused struct members in affs_root_head

On Mon, Aug 26, 2024 at 04:27:36PM +0200, Thorsten Blum wrote:
> Only ptype is actually used. Remove the other struct members.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  fs/affs/amigaffs.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
> index 1b973a669d23..9b40ae618852 100644
> --- a/fs/affs/amigaffs.h
> +++ b/fs/affs/amigaffs.h
> @@ -49,12 +49,6 @@ struct affs_short_date {
>  
>  struct affs_root_head {
>  	__be32 ptype;
> -	__be32 spare1;
> -	__be32 spare2;
> -	__be32 hash_size;
> -	__be32 spare3;
> -	__be32 checksum;
> -	__be32 hashtable[1];
>  };

This is removing documentation, in a way. Since I suspect you were
looking at this due to hashtable, maybe just change that to [] and note
that it (and the other fields) aren't used, but they're kept around to
help document the format.

-- 
Kees Cook