[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZszjFYkoSCfwxUOk@apocalypse>
Date: Mon, 26 Aug 2024 22:18:29 +0200
From: Andrea della Porta <andrea.porta@...e.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Andrea della Porta <andrea.porta@...e.com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Linus Walleij <linus.walleij@...aro.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Derek Kiernan <derek.kiernan@....com>,
Dragan Cvetic <dragan.cvetic@....com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Saravana Kannan <saravanak@...gle.com>,
Bjorn Helgaas <bhelgaas@...gle.com>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, netdev@...r.kernel.org,
linux-pci@...r.kernel.org, linux-arch@...r.kernel.org,
Lee Jones <lee@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in
RP1
Hi Florian,
On 10:02 Wed 21 Aug , Florian Fainelli wrote:
> On 8/20/24 07:36, Andrea della Porta wrote:
> > RaspberryPi RP1 is multi function PCI endpoint device that
> > exposes several subperipherals via PCI BAR.
> > Add an ethernet node for Cadence MACB to the RP1 dtso
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
> > ---
> > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso
> > index d80178a278ee..b40e203c28d5 100644
> > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso
> > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso
> > @@ -78,6 +78,29 @@ rp1_clocks: clocks@...0018000 {
> > <50000000>; // RP1_CLK_ETH_TSU
> > };
> > + rp1_eth: ethernet@...0100000 {
> > + reg = <0xc0 0x40100000 0x0 0x4000>;
> > + compatible = "cdns,macb";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + interrupts = <RP1_INT_ETH IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&macb_pclk &macb_hclk &rp1_clocks RP1_CLK_ETH_TSU>;
> > + clock-names = "pclk", "hclk", "tsu_clk";
> > + phy-mode = "rgmii-id";
> > + cdns,aw2w-max-pipe = /bits/ 8 <8>;
> > + cdns,ar2r-max-pipe = /bits/ 8 <8>;
> > + cdns,use-aw2b-fill;
> > + local-mac-address = [00 00 00 00 00 00];
> > + phy-handle = <&phy1>;
> > + phy-reset-gpios = <&rp1_gpio 32 GPIO_ACTIVE_LOW>;
> > + phy-reset-duration = <5>;
> > +
> > + phy1: ethernet-phy@1 {
> > + reg = <0x1>;
> > + brcm,powerdown-enable;
>
> Undocumented property, and I would like to understand why this needs to be
> specified in the Device Tree? What model of Broadcom Ethernet PHY is being
> used here?
It's a Broadcom BCM5421 transceiver, and that property is intended to support
the optional link-down powersave from DT. It will require slight changes in
drivers/net/phy/broadcom.c too and is not really necessary for minimal support,
so I will drop it in the next iteration.
Many thanks,
Andrea
> --
> Florian
>
Powered by blists - more mailing lists