linux-kernel - Re: [PATCH v9 1/3] usb: gadget: function: move u_f.h to include/linux/usb/func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zsz4e0RUZ9M1OT7v@pengutronix.de>
Date: Mon, 26 Aug 2024 23:49:47 +0200
From: Michael Grzeschik <mgr@...gutronix.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: andrzej.p@...labora.com, asmadeus@...ewreck.org, corbet@....net,
	ericvh@...nel.org, gregkh@...uxfoundation.org,
	kernel@...gutronix.de, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux_oss@...debyte.com, lucho@...kov.net, v9fs@...ts.linux.dev
Subject: Re: [PATCH v9 1/3] usb: gadget: function: move u_f.h to
 include/linux/usb/func_utils.h

On Fri, Aug 23, 2024 at 10:30:09AM +0200, Christophe JAILLET wrote:
>Le 23/08/2024 à 09:36, Michael Grzeschik a écrit :
>>We move the func_utils.h header to include/linux/usb to be
>>able to compile function drivers outside of the
>>drivers/usb/gadget/function directory.
>>
>>Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@...lic.gmane.org>
>>
>>---
>>v8 -> v9: -
>>v7 -> v8: -
>>v6 -> v7: -
>>v5 -> v6: -
>>v4 -> v5:
>>   - renamed to func_utils.h
>>v3 -> v4: -
>>v2 -> v3: -
>>v1 -> v2:
>>   - new introduced patch
>>---
>>  drivers/usb/gadget/configfs.c                              | 2 +-
>>  drivers/usb/gadget/function/f_fs.c                         | 2 +-
>>  drivers/usb/gadget/function/f_hid.c                        | 2 +-
>>  drivers/usb/gadget/function/f_loopback.c                   | 2 +-
>>  drivers/usb/gadget/function/f_midi.c                       | 2 +-
>>  drivers/usb/gadget/function/f_midi2.c                      | 2 +-
>>  drivers/usb/gadget/function/f_sourcesink.c                 | 2 +-
>>  drivers/usb/gadget/u_f.c                                   | 2 +-
>>  drivers/usb/gadget/u_f.h => include/linux/usb/func_utils.h | 2 +-
>>  9 files changed, 9 insertions(+), 9 deletions(-)
>>
>>diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>>index 0e7c1e947c0a0..0f8553795a8ed 100644
>>--- a/drivers/usb/gadget/configfs.c
>>+++ b/drivers/usb/gadget/configfs.c
>>@@ -8,8 +8,8 @@
>>  #include <linux/usb/composite.h>
>>  #include <linux/usb/gadget_configfs.h>
>>  #include <linux/usb/webusb.h>
>>+#include <linux/usb/func_utils.h>
>
>Hi,
>
>Here and in the other files, maybe, keep alphabetic order?
>(even if it is not already completely sorted)
>
>>  #include "configfs.h"
>>-#include "u_f.h"
>>  #include "u_os_desc.h"
>>  int check_user_usb_string(const char *name,
>
>...
>
>>rename from drivers/usb/gadget/u_f.h
>>rename to include/linux/usb/func_utils.h
>>index e313c3b8dcb19..9f2a32c765260 100644
>>--- a/drivers/usb/gadget/u_f.h
>>+++ b/include/linux/usb/func_utils.h
>>@@ -1,6 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  /*
>>- * u_f.h
>>+ * usbf_utils.h
>>   *
>>   * Utility definitions for USB functions
>>   *
>>
>
>Maybe the include guard could be updated as-well?
>

I reworked it in v10:

https://lore.kernel.org/all/20240116-ml-topic-u9p-v10-0-a85fdeac2c52@pengutronix.de/

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)