linux-kernel - Re: [PATCH v2 16/16] overlayfs: Remove ovl_override_creds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzg2kgzd.fsf@intel.com>
Date: Mon, 26 Aug 2024 16:21:42 -0700
From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: brauner@...nel.org, amir73il@...il.com, hu1.chen@...el.com,
 malini.bhandaru@...el.com, tim.c.chen@...el.com, mikko.ylinen@...el.com,
 linux-unionfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 16/16] overlayfs: Remove ovl_override_creds_light()

Miklos Szeredi <miklos@...redi.hu> writes:

> On Thu, 22 Aug 2024 at 03:25, Vinicius Costa Gomes
> <vinicius.gomes@...el.com> wrote:
>>
>> Remove the declaration of this unsafe helper.
>>
>> As the GUARD() helper guarantees that the cleanup will run, it is less
>> error prone.
>
> This statement is somewhat dubious.
>
> I suggest that unless and until the goto issue can be fixed the
> conversion to guards is postponed.

That's a good point. I just want to point out that the issue is only
with the combination of the "plain" (not scoped) GUARD() statements and
'goto'.

But I would be happy to postpone that, if the trouble is not worth it.
As all the performance gains come from the conversion to the _light()
helpers.

>
> Thanks,
> Miklos

Cheers,
-- 
Vinicius