linux-kernel - Re: [PATCH] mtd: ubi: remove unused parameter 'pnum' from add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ef4f6c2-feae-e98b-cc85-a9f92eadaa67@huawei.com>
Date: Mon, 26 Aug 2024 09:17:42 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Wang Zhaolong <wangzhaolong1@...wei.com>, <richard@....at>,
	<miquel.raynal@...tlin.com>, <vigneshr@...com>
CC: <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<yi.zhang@...wei.com>
Subject: Re: [PATCH] mtd: ubi: remove unused parameter 'pnum' from
 add_volume()

在 2024/8/25 16:35, Wang Zhaolong 写道:
> The parameter 'pnum' in the function add_volume() is not used inside the
> function body. This patch removes this unused parameter to clean up the
> code and improve readability.
> 
> This change does not affect the functionality of add_volume() or any other
> part of the UBI subsystem, as the removed parameter is not utilized.
> 
> Signed-off-by: Wang Zhaolong <wangzhaolong1@...wei.com>
> ---
>   drivers/mtd/ubi/attach.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> 
> diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
> index ae5abe492b52..fe9784c90ea4 100644
> --- a/drivers/mtd/ubi/attach.c
> +++ b/drivers/mtd/ubi/attach.c
> @@ -393,8 +393,7 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
>    * to the allocated "av" object in case of success and a negative error code in
>    * case of failure.
>    */
> -static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai,
> -					  int vol_id, int pnum,
> +static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, int vol_id,
>   					  const struct ubi_vid_hdr *vid_hdr)
>   {
>   	struct ubi_ainf_volume *av;
> @@ -576,7 +575,7 @@ int ubi_add_to_av(struct ubi_device *ubi, struct ubi_attach_info *ai, int pnum,
>   	dbg_bld("PEB %d, LEB %d:%d, EC %d, sqnum %llu, bitflips %d",
>   		pnum, vol_id, lnum, ec, sqnum, bitflips);
>   
> -	av = add_volume(ai, vol_id, pnum, vid_hdr);
> +	av = add_volume(ai, vol_id, vid_hdr);
>   	if (IS_ERR(av))
>   		return PTR_ERR(av);
>   
>